Ticket #916 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

0.6.0 working in Oracle environment

Reported by: sheng0110@163.com Assigned to: demian
Priority: normal Milestone: 0.6.0
Component: not categorised Severity: not categorised
Keywords: Cc:

Description

Hi,

Recently I downloaded the 0.6.0 full package, and found out it does not support to install against Oracle database. By changing some of the sql scripts under modules directory -- majorly: user/navigation/block, I successfully install it in my Oracle environment. If you guys interesting, I can submit my changes.

Regards, Ben

Attachments

modules_oci.tar (130.0 kB) - added by sheng0110 on 05/07/06 23:33:30.
Oracle OCI sql files
ben_oci.diff (78.8 kB) - added by sheng0110 on 05/15/06 11:11:50.
result after running "svn diff > ben_oci.diff"

Change History

04/28/06 07:02:20 changed by werner

  • owner changed from somebody to kuckuck.
  • version deleted.

you can submit your patch anyway.

04/28/06 07:42:32 changed by demian

What Werner is trying to say is we'd be very pleased to have your changes, we've had a lot of requests for a working Oracle install.

cheers!

Demian

04/29/06 00:04:59 changed by sheng0110@163.com

Hi,

Since I don't know how to upload my changes (modules_oci.tar) to your server, please let me give some description about my changes here:

Basicly, I made one change in WizardTestDbConnection?.php to allow to support Oracle, and make another work arround change in seagull/lib/SGL/Task/Install.php to bypass error after SQL execution.

1. Change "seagull/lib/SGL/Install/WizardTestDbConnection.php" to support Oracle

[ben@ Install]$ diff WizardTestDbConnection?.php WizardTestDbConnection?.php.orig 113c113 < $radio[] = &$this->createElement('radio', 'type', , "oci8", 'oci8_SGL'); ---

# $radio[] = &$this->createElement('radio', 'type', , "oci8", 'oci8_SGL');

136c136 < $radio[] = &$this->createElement('radio', 'port', ,"1521 (Oracle default)", 1521); ---

# $radio[] = &$this->createElement('radio', 'port', ,"1521 (Oracle default)", 1521);

2. Work arround change made in "seagull/lib/SGL/Task/Install.php" since I still found few bug exist during Oracle SQL execution.

in: class SGL_Task_VerifyDbSetup

[ben@ Install]$ diff WizardTestDbConnection?.php WizardTestDbConnection?.php.orig 704c704 < if (!SGL_Install_Common::errorsExist()) { //Ben's change ---

if (SGL_Install_Common::errorsExist()) {

BTW, there are bugs during install language in database, so do not select this option.

My change file list is as follows:

[ben@pms seagull]$ tar tvf modules_oci.tar -rw-rw-r-- ben/ben 186 2006-04-28 16:20:42 modules/drop.sh -rw-rw-r-- ben/ben 671 2006-04-28 16:20:39 modules/block/data/constraints.oci.sql -rw-rw-r-- ben/ben 2482 2006-04-28 16:20:39 modules/block/data/data.default.oci.sql -rw-rw-r-- ben/ben 3749 2006-04-28 16:20:39 modules/block/data/data.sample.oci.sql -rw-rw-r-- ben/ben 2265 2006-04-28 16:20:39 modules/block/data/schema.oci.sql -rw-rw-r-- ben/ben 1297 2006-04-28 16:20:40 modules/contactus/data/data.default.oci.sql -rw-rw-r-- ben/ben 847 2006-04-28 16:20:40 modules/contactus/data/schema.oci.sql -rw-rw-r-- ben/ben 0 2006-04-28 16:20:40 modules/default/data/constraints.oci.sql -rw-rw-r-- ben/ben 4015 2006-04-28 16:20:40 modules/default/data/data.default.oci.sql -rw-rw-r-- ben/ben 3621 2006-04-28 16:20:40 modules/default/data/schema.oci.sql -rw-rw-r-- ben/ben 554 2006-04-28 16:20:41 modules/documentor/data/data.default.oci.sql -rw-rw-r-- ben/ben 736 2006-04-28 16:20:40 modules/export/data/data.default.oci.sql -rw-rw-r-- ben/ben 1516 2006-04-28 16:20:39 modules/faq/data/data.default.oci.sql -rw-rw-r-- ben/ben 748 2006-04-28 16:20:39 modules/faq/data/schema.oci.sql -rw-rw-r-- ben/ben 1158 2006-04-28 16:20:41 modules/guestbook/data/data.default.oci.sql -rw-rw-r-- ben/ben 653 2006-04-28 16:20:41 modules/guestbook/data/schema.oci.sql -rw-rw-r-- ben/ben 566 2006-04-28 16:20:40 modules/messaging/data/constraints.oci.sql -rw-rw-r-- ben/ben 3039 2006-04-28 16:20:40 modules/messaging/data/data.default.oci.sql -rw-rw-r-- ben/ben 408 2006-04-28 16:33:05 modules/messaging/data/data.sample.oci.sql -rw-rw-r-- ben/ben 2189 2006-04-28 16:20:40 modules/messaging/data/schema.oci.sql -rw-rw-r-- ben/ben 0 2006-04-28 16:20:42 modules/navigation/data/constraints.oci.sql -rw-rw-r-- ben/ben 7013 2006-04-28 16:20:42 modules/navigation/data/data.default.oci.sql -rw-rw-r-- ben/ben 3719 2006-04-28 16:20:42 modules/navigation/data/schema.oci.sql -rw-rw-r-- ben/ben 2761 2006-04-28 16:20:39 modules/newsletter/data/data.default.oci.sql -rw-rw-r-- ben/ben 798 2006-04-28 16:20:39 modules/newsletter/data/schema.oci.sql -rw-rw-r-- ben/ben 1376 2006-04-28 16:20:39 modules/publisher/data/constraints.oci.sql -rw-rw-r-- ben/ben 7915 2006-04-28 16:20:39 modules/publisher/data/data.default.oci.sql -rw-rw-r-- ben/ben 4803 2006-04-28 16:20:39 modules/publisher/data/data.sample.oci.sql -rw-rw-r-- ben/ben 7868 2006-04-28 16:20:39 modules/publisher/data/schema.oci.sql -rw-rw-r-- ben/ben 804 2006-04-28 16:20:39 modules/randommsg/data/data.default.oci.sql -rw-rw-r-- ben/ben 572 2006-04-28 16:20:39 modules/randommsg/data/schema.oci.sql -rw-rw-r-- ben/ben 1332 2006-04-28 16:20:39 modules/user/data/constraints.oci.sql -rw-rw-r-- ben/ben 16495 2006-04-28 16:29:38 modules/user/data/data.default.oci.sql -rw-rw-r-- ben/ben 10298 2006-04-28 16:20:39 modules/user/data/schema.oci.sql

if you need to reinstall whole thing, cd seagull/modules, and execute: "sh drop.sh" -- which will cleanup all existing oracle schemas.

Regards, Ben

04/29/06 04:49:32 changed by demian

Hi Ben - sounds like a very complete patch, I'm looking forward to reviewing it. To attach patches to Trac tickets (this is a Trac ticket) do the following:

1) login to Trac

2) go the the Attachments section, right under the ticket description at the top, and hit the 'attach file' button

Let me know if have any probs.

cheers

Demian

04/29/06 23:44:13 changed by ben <sheng0110@163.com>

how and where can I register as Trac user ?

04/30/06 08:19:17 changed by demian

05/07/06 23:33:30 changed by sheng0110

  • attachment modules_oci.tar added.

Oracle OCI sql files

05/10/06 08:47:31 changed by demian

  • owner changed from kuckuck to demian.
  • status changed from new to assigned.

Hey Ben

I just noticed your uploaded .tar, somehow i missed it when it came in. that's all applied now, thanks for the contribution! definitely worthly of an announcement when it's complete.

the notes your left in the ticket are hard to read due to lack of formatting, can u submit a patch with the final changes required to make an OCI install work smoothly?

Code/SubmittingPatches

cheers

Demian

05/15/06 11:11:50 changed by sheng0110

  • attachment ben_oci.diff added.

result after running "svn diff > ben_oci.diff"

05/22/06 19:23:09 changed by demian

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [2023]) OCI schema and data now up to date, fixes #916