Ticket #1384 (assigned defect)

Opened 7 years ago

Last modified 9 months ago

In PEAR::DB 1.7.8RC1 new method DB::getDSNString() was introduced

Reported by: lakiboy Assigned to: demian (accepted)
Priority: high Milestone: 1.1
Component: SGL - DB Severity: open
Keywords: Cc:

Description

We can use this native method instead of Seagull's SGL_DB::getDSN(SGL_*_STRING).

Attachments

getDSNString_rev2917.diff (5.6 kB) - added by lakiboy on 01/31/07 13:57:11.
1384.patch (8.4 kB) - added by aj on 07/18/07 01:51:38.
Patch against branches/0.6-bugfix rev 3274

Change History

01/31/07 13:56:32 changed by lakiboy

  • owner changed from lakiboy to demian.

Recently PEAR::DB 1.7.8 was released and is required for the following patch.

01/31/07 13:57:11 changed by lakiboy

  • attachment getDSNString_rev2917.diff added.

02/01/07 08:00:48 changed by lakiboy

PEAR::DB devs broke BC with their DB 1.7.7 release. We have to quote table name before using DB_mysql#tableInfo().

02/15/07 17:40:36 changed by demian

  • owner changed from demian to lakiboy.

this kills my DB connectivity, i get msg:

 [nativecode=1102 ** Incorrect database name ':3306/seagull'] ** mysql_SGL(mysql)://root:@unix(localhost):3306/seagull

using latest DB, 1.7.9

02/16/07 09:43:12 changed by demian

seems patch works for tcp connections, not unix sockets

02/18/07 06:21:02 changed by lakiboy

  • owner deleted.

Correct, works fine on Windows using tcp. Seems there is no chance for me to debug unix sockets i reassign this ticket to anybody.

03/22/07 06:48:12 changed by demian

  • milestone changed from 0.6.2 to 0.6.3.

can someone test this with unix sockets, ie on mac or linux

07/18/07 01:51:38 changed by aj

  • attachment 1384.patch added.

Patch against branches/0.6-bugfix rev 3274

07/18/07 01:53:52 changed by aj

  • owner set to demian.

Hi guys,

The added patch has been tested using tcp on a remote and local db. I've also updated the unit tests so they work properly.

11/09/07 09:48:40 changed by demian

  • milestone changed from 0.6.3 to 0.9.0 - polishing.

i took too long to apply this :-( we now have quite a few errors in patch:

Demian-Turners-Laptop:0.6-bugfix demian$ patch -p0 --dry-run < 1384.patch 
patching file etc/sglBridge.php
Hunk #1 succeeded at 49 (offset 2 lines).
patching file lib/SGL/DB.php
Hunk #1 succeeded at 105 (offset -1 lines).
Hunk #2 FAILED at 135.
Hunk #3 FAILED at 144.
2 out of 3 hunks FAILED -- saving rejects to file lib/SGL/DB.php.rej
patching file lib/SGL/tests/DbTest.wdb.php
patching file tests/classes/DB.php
Hunk #1 FAILED at 99.
1 out of 1 hunk FAILED -- saving rejects to file tests/classes/DB.php.rej

02/26/13 12:21:25 changed by demian

  • priority changed from normal to high.
  • status changed from new to assigned.