Ticket #1361 (closed defect: fixed)

Opened 5 years ago

Last modified 2 years ago

Wrong file names for theme graphics

Reported by: deadmoon Assigned to: deadmoon
Priority: normal Milestone: 0.6.1
Component: themes - default_admin Severity: open
Keywords: Cc:

Description

sort_asc.gif and sort_desc.gif do no show up in the admin section. They have to be named as sort_ASC.gif and sort_DESC.gif.

Change History

12/27/06 12:05:06 changed by demian

  • owner changed from jcasanova to demian.
  • status changed from new to assigned.
  • milestone set to 0.6.2.

i'll fix that in the repo

12/27/06 13:27:01 changed by deadmoon

not a problem of the file names. i think a strtolower(); in modules/classes/UserMgr.php is missing

$input->sortOrder = strtolower(SGL_Util::getSortOrder($req->get('frmSortOrder')));

12/27/06 21:08:57 changed by demian

  • owner changed from demian to deadmoon.
  • status changed from assigned to new.

looking at the code the images are named correctly and referenced correctly. to be specific, in the user manager when i click on id, username, role, etc I get the sort order arrows.

so what are you referring to?

12/28/06 04:43:31 changed by deadmoon

  • milestone changed from 0.6.2 to 0.6.1.

A fresh installation of Seagull (stable) does not show the sort icons in the UserManager?. They are references as sort_ASC.gif. Changing the filename to lowercase is wrong, becuase this will solve the problem in the UserManager?, but raise up the same problem in an other module. So the correct fix is the extra "strtolower" in modules/classes/UserMgr.php

$input->sortOrder = strtolower(SGL_Util::getSortOrder($req->get('frmSortOrder')));

02/08/10 14:28:03 changed by demian

  • status changed from new to closed.
  • resolution set to fixed.