Ticket #1060 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Permissions ignored when scanning at PermissionMgr

Reported by: rofranco Assigned to: demian
Priority: normal Milestone: 0.6.0
Component: module - user Severity: minor
Keywords: Cc:

Description

We have found that some permissions don't get listed when scanning permissions in "Detect & Add" option. There are two reasons why they aren't getting added:

1) The module name is not taken into account when comparing perms in order to see if they already exist. This causes that if you have two different managers with the same name and same action in different modules, Seagull considers them as being the same.

2) Any action that contains the word "redirect" gets ignored. We have an UrlMgr? that handles redirections in our application and one of its actions is called: redirect. I believe that the only special case for redirect* actions should be redirectToDefault, and any other redirect action should be managed as any other.

I'm including a patch to PermissionMgr? that corrects both problems.

Attachments

patch_scan_perms.diff (1.1 kB) - added by rofranco on 07/17/06 04:01:54.

Change History

07/17/06 04:01:54 changed by rofranco

  • attachment patch_scan_perms.diff added.

07/17/06 11:19:52 changed by lakiboy

I don't agree about redirects. In my managers I have actions like redirectToEdit or redirectToInfo etc. Probably it is better to match redirectTo* actions instead of just redirect*.

07/17/06 11:49:25 changed by demian

agreed, seagull also has around 5-6 redirectToFoo methods.

07/17/06 20:02:46 changed by demian

  • status changed from new to closed.
  • resolution set to fixed.

(In [2206]) added perms search patch, with exceptions in comments, fixes #1060